The Energon Pub

I wonder if mission times should be extended automatically if only 1 character is in a mission instead of processing a mission like that. Or focus on bringing more players back to the game once more things are fixed and that problem will resolve itself?

Mission Fix Count: 1322

[INFO] Starting fix-stuck-missions tool ...
[INFO] Yes, this script should resolve unfinished missions and missions with Unknowns declared as winner.
[INFO] In addition to that, this will help solve what's going wrong with hmw_battle processing.

[INFO] Mission limit currently set to: 1. This can be adjusted as needed as more examples are needed.

[OK] 1 missions found.

[INFO] Processing stuck Mission: https://www.seibertron.com/heavymetalwa ... _id=370194
[OK] 2 characters found for mission (370194)
[INFO] Character roster for mission 370194:
[->] character_id=89938 user_id=41877 faction=1 level=10 health=100
[->] character_id=100911 user_id=75464 faction=2 level=11 health=100

[->] Resetting character_id=89938
[OK] Health set to 100 for character_id=89938
[OK] Doing row inserted/updated for character_id=89938, mission_id=370194

[->] Resetting character_id=100911
[OK] Health set to 100 for character_id=100911
[OK] Doing row inserted/updated for character_id=100911, mission_id=370194

[DEBUG] Characters have been reset into doing for mission 370194. Verify DB state before continuing.

[OK] Queued mission_id=370194 for immediate processing

[OK] Tagged missions in hmw_process_queue with process_tag=68d21c945341a

[INFO]Found 1 missions in the process queue with tag 68d21c945341a.

[INFO] Running queued mission 370194
[DONE] Mission 370194 processed and marked repaired_date=1758600340
[OK] Character 89938 auto-healed and cleared from doing
[OK] Character 100911 auto-healed and cleared from doing

[SUMMARY] Auto-healed 2 characters for mission 370194

[INFO] Finished.

Seibertron wrote:With that out of the way, can you guys provide me with any additional info about the weird battle steve2275 just posted? Anything any of you can think of that would trigger that?

Can't offer any extra (new) info, but that's the same bug that's been happening since June - a character apparently set to 0 health either when they join the mission or when it starts. Those are the two places I'd start looking first as I know there have been changes. I have two main suspicions I'd want to check: first, that a null is getting introduced somewhere and automatically converted to a 0 in the health column; secondly, that the battle might be getting run more than once if the queue system has picked up a bug in the June updates and lost its protection against running the same battle twice.

Re that second option: The battle script had protection against picking up the same battle in overlapping runs, but if that's gone away then it's possible that one run processed the battle and updated mission_characters with the characters' end states, and then a second run picked up the updated character entries, re-ran the battle with those as the starting values (including some characters being on 0 health) and overwrote the log file. That would actually fit with the evidence we've occasionally seen of characters not being 'ignored' but having damage and XP totals that don't match the log.

Seibertron wrote:I wonder if mission times should be extended automatically if only 1 character is in a mission instead of processing a mission like that. Or focus on bringing more players back to the game once more things are fixed and that problem will resolve itself?

Jeez, no, don't extend the mission time! I tend to be on at quiet times on the site and that could extend missions by literally an hour or more, during which time I could otherwise have been getting the XP from multiple missions. If you're going to change the mission time at all, better to have an unopposed mission finish immediately rather than waiting the full 20 minutes - extending the time would directly penalise players in different timezones by making empty missions even less valuable.

My proposed fix for this was to add NPCs that could fill out an unopposed mission and ensure players got an actual battle. Attracting new players / Bringing lapsed players back will mitigate it organically, but there have always been times when no opposing bots joined a mission - that's why the 'unopposed' texts were added in the first place.

Mission Fix Count: 1782

[INFO] Starting fix-stuck-missions tool ...
[INFO] Yes, this script should resolve unfinished missions and missions with Unknowns declared as winner.
[INFO] In addition to that, this will help solve what's going wrong with hmw_battle processing.

[INFO] Mission limit currently set to: 1. This can be adjusted as needed as more examples are needed.

[OK] 1 missions found.

[INFO] Processing stuck Mission: https://www.seibertron.com/heavymetalwa ... _id=370695
[OK] 2 characters found for mission (370695)
[INFO] Character roster for mission 370695:
[->] character_id=89942 user_id=41877 faction=1 level=10 health=100
[->] character_id=100911 user_id=75464 faction=2 level=11 health=100

[->] Resetting character_id=89942
[OK] Health set to 100 for character_id=89942
[OK] Doing row inserted/updated for character_id=89942, mission_id=370695

[->] Resetting character_id=100911
[OK] Health set to 100 for character_id=100911
[OK] Doing row inserted/updated for character_id=100911, mission_id=370695

[DEBUG] Characters have been reset into doing for mission 370695. Verify DB state before continuing.

[OK] Queued mission_id=370695 for immediate processing

[OK] Tagged missions in hmw_process_queue with process_tag=68d226f9dcb5e

[INFO]Found 1 missions in the process queue with tag 68d226f9dcb5e.

[INFO] Running queued mission 370695
[DONE] Mission 370695 processed and marked repaired_date=1758603002
[OK] Character 89942 auto-healed and cleared from doing
[OK] Character 100911 auto-healed and cleared from doing

[SUMMARY] Auto-healed 2 characters for mission 370695

[INFO] Finished.

Glyph wrote:Can't offer any extra (new) info, but that's the same bug that's been happening since June - a character apparently set to 0 health either when they join the mission or when it starts. Those are the two places I'd start looking first as I know there have been changes. I have two main suspicions I'd want to check: first, that a null is getting introduced somewhere and automatically converted to a 0 in the health column; secondly, that the battle might be getting run more than once if the queue system has picked up a bug in the June updates and lost its protection against running the same battle twice.

It's probably something to do with the first option. I'll have to ponder it or try to gather examples that demonstrate that and work it backwards.

Glyph wrote:Jeez, no, don't extend the mission time!

Your explanation makes sense. Thanks for being upfront about it and explaining it.

Mission Fix Count: 1818

[INFO] Starting fix-stuck-missions tool ...
[INFO] Yes, this script should resolve unfinished missions and missions with Unknowns declared as winner.
[INFO] In addition to that, this will help solve what's going wrong with hmw_battle processing.

[INFO] Mission limit currently set to: 1. This can be adjusted as needed as more examples are needed.

[OK] 1 missions found.

[INFO] Processing stuck Mission: https://www.seibertron.com/heavymetalwa ... _id=370746
[OK] 2 characters found for mission (370746)
[INFO] Character roster for mission 370746:
[->] character_id=90316 user_id=890 faction=1 level=10 health=100
[->] character_id=99390 user_id=80445 faction=2 level=10 health=100

[->] Resetting character_id=90316
[OK] Health set to 100 for character_id=90316
[OK] Doing row inserted/updated for character_id=90316, mission_id=370746

[->] Resetting character_id=99390
[OK] Health set to 100 for character_id=99390
[OK] Doing row inserted/updated for character_id=99390, mission_id=370746

[DEBUG] Characters have been reset into doing for mission 370746. Verify DB state before continuing.

[OK] Queued mission_id=370746 for immediate processing

[OK] Tagged missions in hmw_process_queue with process_tag=68d22868c8a06

[INFO]Found 1 missions in the process queue with tag 68d22868c8a06.

[INFO] Running queued mission 370746
[DONE] Mission 370746 processed and marked repaired_date=1758603369
[OK] Character 90316 auto-healed and cleared from doing
[OK] Character 99390 auto-healed and cleared from doing

[SUMMARY] Auto-healed 2 characters for mission 370746

[INFO] Finished.

I stopped the fix script from running further tonight. Hitting the sack. Will process more tomorrow.

I stopped the fix script from running further tonight. Hitting the sack. Will process more tomorrow.

thank you for your hard work
the sites seems like its old fast self again

steve2275 wrote:thank you for your hard work
the sites seems like its old fast self again

Thanks, steve2275.

Are missions working for you?

Mine seem to be working great now. I've run all 12 bots through missions yesterday and in today. The missions I had opponents in seemed to work correctly.

That is great to hear. I still saw some oddities in battle processing the other day when I ran the script to restore missions.

I think I need to do the same for arena battles next, but they should be working now that I resolved the php version class conflict that I introduced last month when I cleaned up some other code that handles factions (so that factions are not hard coded and are handled dynamically).