Hello all,
The issues with the ":80" port in the URLs and the malformed pagination URLs in forum topics should now be resolved. Here's a summary of the steps I took to address these:
- Resolved ":80" Port Issue:
The URL issue that included the ":80" port has been fixed. However, if you received any topic reply notifications with this in the URL, you will need to manually remove ":80" when copying and pasting the link. - Fixed Pagination Issue:
I identified and fixed the random pagination problem that occurred when first viewing a forum or topic. This issue was replicated in an incognito window, and it was determined that the session ID (sid) variable was causing the malformed links. The issue only seemed to happen on the first load of a page. - Updated phpBB Session Handling:
In response to the above issue, I modified the phpBB code by removing the session ID (sid) variable from the URLs. This was a long-standing issue that has been present since the installation of phpBB 3.0 back in 2007. Removing the session ID from the URLs should prevent this problem from recurring.
In addition, here's a brief summary of the issues related to phpBB in the /energonpub/ directory that were identified and addressed:
- ":80" Port in URLs:
The inclusion of the ":80" port in URLs was causing issues, particularly in topic reply notifications. I fixed the issue, but users who received notifications with the ":80" port in the URL will need to manually remove it when copying and pasting the link. - Malformed Pagination Links with sid Variable:
A random issue occurred where pagination links for forum topics were broken, particularly when first viewing a page. This was caused by the sid (session ID) variable being added to the URLs. The problem was replicated in an incognito window and was fixed by removing the sid variable from the URLs, which had been a long-standing problem since the installation of phpBB 3.0. - Manual Session Handling in viewforum.php and viewtopic.php:
The session management in phpBB was customized to manually call $user->session_begin() instead of relying on the automatic session handling in common.php. This was a result of the custom SEO URL modifications and caused issues with session handling on the initial page load.
As a reminder, yes, I am aware that we're still using phpBB 3.0, which is quite old. The platform has been extensively modified over the years to suit Seibertron.com’s needs. While upgrading to a newer version hasn't been feasible due to the level of customization, I plan to do a more comprehensive overhaul this year. The goal will be to rewrite much of the phpBB code to better fit our specific needs, while maintaining the database structure.
Thank you for your patience, and please let me know if any further issues arise.