Seibertron wrote:Can one of you share the specific URL where the error is happening with the activiation of more than 6 bots at a time? Thank you.
From the registry (registry.php)
I found that I couldn't activate more than 6 in a single submission, but I could activate less than 6, then activate a few more in another submission to take the active total over 6. Once I had 6 or more active in total, I could no longer activate more. In the example below, I activated 4 bots, then activated 3 more in a second submission.
As the activation check is on the registry page, the missions page was also perfectly happy to let me put all 9 bots into missions at the same time after I'd activated them this way (as 5 then 4 more).
So it looks like the check for how many bots are currently active has been broken - the page correctly checks that the player isn't submitting more than 6 bots
at once, but doesn't check that the form submission plus the existing active bots totals 6 or less.
Checking an old backup - and I assume the code is still similar - the check used to happen at the entry point to the
- Code: Select all
elseif ($action == "activate") {
branch. The page pulled the current number of active bots into
$active_count at the top of the page, then had a guard clause to check that
(count($_POST['character_id']) + $active_count) wasn't more than 6 before proceeding to activate each submitted bot. It looks like either this guard clause has been removed, or (more likely) the
$active_count query isn't working properly and is getting counted as zero.